Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Printer::printAttributes protected (was private) #123

Closed
wants to merge 10 commits into from

Conversation

Aterlupus
Copy link

Made Printer::printAttributes protected (was private) to enable possibility of changing its behavior by user (open-closed principle)

  • bug fix - since Printer is designed to be extended for modified behavior and "private" accessor made that harder
  • BC break? - no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants