Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PER Coding Style 2.0 #155

Closed
taka-oyama opened this issue Mar 1, 2024 · 2 comments
Closed

Support for PER Coding Style 2.0 #155

taka-oyama opened this issue Mar 1, 2024 · 2 comments

Comments

@taka-oyama
Copy link

We use php-cs-fixer to format out code to be aligned with PER coding style.

This library comes close by supporting PSR-12 but there are some minor differences.

One in particular that we've encountered is how multi-line methods are formatted.

PSR-12 output the below

    public function add(
        ?string $id,
    ): void
    {

but PER wants it to be like this.

    public function add(
        ?string $id,
    ): void {

We get diffs in our git everytime we generate the new code and it's very cumbersome.

Would it be possible to add support for this?

Btw, thanks for creating this great library. We use it in almost all our projects and is a joy to use.

@taka-oyama
Copy link
Author

Actually, I was wrong... PSR-12 and PER's formatting is the same. So I guess the formatting is just incorrect.

@taka-oyama
Copy link
Author

Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant