-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heredoc and Nowdoc converted to inline string when parsed #151
Comments
GromNaN
added a commit
to GromNaN/mongo-php-builder
that referenced
this issue
Jan 17, 2024
GromNaN
changed the title
Heredoc and Nowdoc converted to string when parsed
Heredoc and Nowdoc converted to inline string when parsed
Jan 17, 2024
Thanks for the fix @dg. Isn't it possible to keep the heredoc/nowdoc in the function body? |
In principle, since PHP 7.3 it is possible, I will try to implement it. |
dg
added a commit
that referenced
this issue
Jan 17, 2024
@GromNaN it should be working in master by now, can you test it? |
Perfect, it works. The upgrade to |
dg
added a commit
that referenced
this issue
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: 4.1.2
Bug Description
When a PHP file contains a heredoc or a nowdic, it is converted to a double-quoted string by the parsed.
This transforms the contents of a the files that are modified using this package, and this can generate invalid PHP syntax if the string contains a double quote.
Steps To Reproduce
Create a file that contains a heredoc or a nowdoc (called
file.php
):Create a script that reads this file, parse it and dump it:
Run the script.
The result is an invalid PHP file with the string inlined in double quotes.
Expected Behavior
The output should be identical to the input
file.php
.Possible Solution
No idea, sorry.
The text was updated successfully, but these errors were encountered: