Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract fails on array properties with class constant keys #143

Closed
kynx opened this issue Oct 26, 2023 · 0 comments
Closed

Extract fails on array properties with class constant keys #143

kynx opened this issue Oct 26, 2023 · 0 comments

Comments

@kynx
Copy link

kynx commented Oct 26, 2023

Version: 4.1.1

Bug Description

If a class property is an array and the default value uses class constants as keys, extracting the class throws a TypeError: Illegal offset type

Steps To Reproduce

	class Class1
	{
		public $constKey = [self::class => 'foo'];
	}

Expected Behavior

The property is extracted.

Possible Solution

This was broken by something around d915b7f#diff-634a48b3c9efd3101dad0b38a2be84c212cdf9d9e73246cf36de82e6e26a876eR424-R426

I'll do a PR with a test to reproduce and see If I can figure out a fix.
kynx pushed a commit to kynx/php-generator that referenced this issue Oct 26, 2023
Test to reproduce nette#143
cf3d118
@kynx kynx mentioned this issue Oct 26, 2023
Closed
kynx pushed a commit to kynx/php-generator that referenced this issue Oct 26, 2023
Test to reproduce nette#143
a4d3b4f
@dg dg closed this as completed in 0106e52 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test to reproduce #143 kynx/php-generator
1 participant
@kynx