Enable to suppress Suspicious dumping error#320
Open
survik1 wants to merge 22 commits intonette:masterfrom
Open
Enable to suppress Suspicious dumping error#320survik1 wants to merge 22 commits intonette:masterfrom
survik1 wants to merge 22 commits intonette:masterfrom
Conversation
…' moved to visitors
…st-class callables
added Definition::getDescriptor(), Helpers::entityToString()
Author
|
@dg Hello, could you please comment this pr in any way? |
Member
|
Please try to describe why such objects are dumped, i.e. very simply what the object is and how it is listed in the configuration file. |
3d8d9ae to
e267934
Compare
Author
|
@dg Hi, sorry for delay, I wanted to trim our code a bit. We have Extension around Kafka. It parses configuration definitions from rather large neon file, completes it into KafkaConfig class and pass this class to extension services. class KafkaExtension extends CompilerExtension
{
public function __construct()
{
$this->kafkaConfig = new KafkaConfig();
}
protected function loadConfiguration(): void
{
// ...
foreach ($clusters as $clusterName => $clusterConf) {
// ...
$clusterTemplate = new ClusterTemplate($clusterName, [], $options, $callbacks);
$this->kafkaConfig->addClusterTemplate($clusterTemplate);
// ...
}
public function setupDefinitions(): void
{
$builder = $this->getContainerBuilder();
$builder->addDefinition($this->prefix('producerFactory'))
->setFactory(ProducerFactory::class)
->setAutowired($this->config[self::AUTOWIRED] ?? true)
->setArguments([$this->kafkaConfig, $this->configurationHelper]);
// ...
}
}KafkaConfig class is not a service, its more of ValueObject for all configuration data. final readonly class ConsumerFactory
{
public function __construct(
private KafkaConfig $kafkaConfig,
private ConfigurationHelper $configurationHelper
) {
}
public function createConsumer(string $consumerName, ?Callbacks $callbacks = null, array $customConf = []): KafkaConsumer
{
$consumerTemplate = $this->kafkaConfig->getConsumerTemplate($consumerName);
// ...
return new KafkaConsumer($conf, $consumerTemplate);
}
}So yeah, its for ValueObjects. And its kinda hard to modify it because I don't even understand your intentions here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nette/Di introduced warning about suspicious dumping of objects. While i understand the intention, this little warning forces as to rewritte significant amount of value objects that we just pass around. These value objects commonly implements specific interfaces, following pattern of private variable and getters. Even though we could spend time to rewrite everything into PHP 8.4 pattern of
public protected(set) $variableproperties (and hopefully don't run into any more complicated obstacle), I belive that this dev-oriented warning should be possible to suspend by dev.I propose to add a class attribute that would prevent raising up this warning.
I was unable to add any tests as I don't know how to test trigger_error() function, but I am willing to add them if you point me in some direction.