Add enum references method#185
Open
secret-point wants to merge 1 commit intonetspective-labs:mainfrom
Open
Conversation
shah
reviewed
Feb 13, 2024
Contributor
shah
left a comment
shah
left a comment
There was a problem hiding this comment.
Did you check to see if any changes were required in the unit test?
|
|
||
| // deno-lint-ignore no-explicit-any | ||
| type Any = any; // make it easier on Deno linting | ||
| interface ForeignKeyReference<Context extends SQLa.SqlEmitContext> { |
Contributor
There was a problem hiding this comment.
Should be exportable by default.
| // deno-lint-ignore no-explicit-any | ||
| type Any = any; // make it easier on Deno linting | ||
| interface ForeignKeyReference<Context extends SQLa.SqlEmitContext> { | ||
| tableName: string; |
Contributor
There was a problem hiding this comment.
Use readonly properties by default.
| type Any = any; // make it easier on Deno linting | ||
| interface ForeignKeyReference<Context extends SQLa.SqlEmitContext> { | ||
| tableName: string; | ||
| columnName: string; |
Contributor
There was a problem hiding this comment.
Use readonly properties by default.
| export interface EnumTableDefn<Context extends SQLa.SqlEmitContext> { | ||
| readonly enumTableNature: "text" | "numeric"; | ||
| readonly seedDML: string | SQLa.SqlTextSupplier<Context>[]; | ||
| references: { |
Contributor
There was a problem hiding this comment.
Use readonly properties by default (readonly references).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.