Skip to content

Conversation

@nntu
Copy link

@nntu nntu commented Oct 25, 2025

No description provided.

@kellybyrd
Copy link

Two things:

  1. I'm not part of the project, but looking at the history of other PRs it seems unlikely they'll take this PR. The project maintainers seem to want new transports to be implemented outside of the project rather than have more code they have to test and maintain.

That's the route I took with my changes to netflow2ng, which uses goflow2 as a library and then adds it's own transport and format.

  1. It's sort of an incomplete PR. The code might be fine, but you don't give any overview, just adding two new transports. The commit message and the PR description provide no detail on the change.

@nntu
Copy link
Author

nntu commented Nov 9, 2025

Thanks for the detailed feedback. This is very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants