Fixes based on cppcheck reports

- Made `Signal<..>::Interface::Interface(SignalType*)` explicit - Calling constructor in Signal copy-constructor - Made some functions const
netromdk · Aug 22, 2020 · 510409e · 510409e
1 parent f0fdb40
commit 510409e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/sigs.h b/sigs.h
@@ -174,7 +174,7 @@ class Signal<Ret(Args...)> final {
   /// Interface that only exposes connect and disconnect methods.
   class Interface final {
   public:
-    Interface(SignalType *sig) noexcept : sig_(sig)
+    explicit Interface(SignalType *sig) noexcept : sig_(sig)
     {
     }
 
@@ -225,7 +225,7 @@ class Signal<Ret(Args...)> final {
     }
   }
 
-  Signal(const Signal &rhs) noexcept
+  Signal(const Signal &rhs) noexcept : Signal()
   {
     Lock lock1(entriesMutex);
     Lock lock2(const_cast<Signal &>(rhs).entriesMutex);

diff --git a/tests/General.cc b/tests/General.cc
@@ -44,7 +44,7 @@ TEST(General, functor)
 {
   class AddOneFunctor {
   public:
-    void operator()(int &i)
+    void operator()(int &i) const
     {
       i++;
     }
@@ -63,7 +63,7 @@ TEST(General, instanceMethod)
 {
   class Foo {
   public:
-    void test(int &i)
+    void test(int &i) const
     {
       i++;
     }

diff --git a/tests/Interface.cc b/tests/Interface.cc
@@ -41,7 +41,7 @@ TEST(Interface, functor)
 {
   class AddOneFunctor {
   public:
-    void operator()(int &i)
+    void operator()(int &i) const
     {
       i++;
     }
@@ -60,7 +60,7 @@ TEST(Interface, instanceMethod)
 {
   class Foo {
   public:
-    void test(int &i)
+    void test(int &i) const
     {
       i++;
     }