Disconnect with no slot will disconnect all

netromdk · Aug 22, 2020 · 340ccf9 · 340ccf9
1 parent e6f32ce
commit 340ccf9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/sigs.h b/sigs.h
@@ -295,7 +295,9 @@ class Signal<Ret(Args...)> final {
     eraseEntries();
   }
 
-  void disconnect(std::optional<Connection> conn) noexcept
+  /// Disconnects \p conn from signal.
+  /** If no value is given, all slots are disconnected. */
+  void disconnect(std::optional<Connection> conn = std::nullopt) noexcept
   {
     if (!conn) {
       clear();

diff --git a/tests/General.cc b/tests/General.cc
@@ -277,3 +277,12 @@ TEST(General, empty)
   s.clear();
   ASSERT_TRUE(s.empty());
 }
+
+TEST(General, disconnectWithNoSlotClearsAll)
+{
+  sigs::Signal<void()> s;
+  s.connect([] {});
+  s.connect([] {});
+  s.disconnect();
+  ASSERT_TRUE(s.empty());
+}