Allow any address family in net_test #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samribeiro , thank you for the PR! |
ybubnov
reviewed
Aug 10, 2018
net_test.go
Outdated
| @@ -162,7 +162,7 @@ func TestListener(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestDial(t *testing.T) { | |||
| ln, err := Listen("tcp4", "127.0.0.1:0") | |||
| ln, err := Listen("tcp", ":0") | |||
There was a problem hiding this comment.
That was like this some time before, until I started get errors on Travis CI.
There was a problem hiding this comment.
I noticed that travis is complaining. I wonder if it is a problem with travis then. Perhaps specifying a port can help. Testing.
There was a problem hiding this comment.
confident this was a bug in go interpreting/parsing IPv6 addresses that got fixed before 1.9. The issue probably started being noticeable when they defaulted travis to IPv6. But is just a guess, suggestion works now and is good enough for me too.
ybubnov
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.