New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

padLen() was Computed Twice #129

Merged

ybubnov merged 1 commit into netrack:master from kent-h:bug/double-padlen

Apr 14, 2018

Contributor

kent-h commented Apr 13, 2018

padLen() is computed internally by makePad(), so matchlen should be passed as-is.


          Fixed issue where padLen() was computed twice, leading to an incorrec…

3ccdf4d

…t pad length.

ybubnov self-requested a review

April 14, 2018 15:47

ybubnov added kind/bug area/protocol reviewed/looks-good-to-me reviewed/merge-on-green labels

Member

ybubnov commented Apr 14, 2018 •

edited

Loading

That is nice gotcha! Many thanks.

ybubnov approved these changes

View reviewed changes

ybubnov merged commit 69f22a2 into netrack:master

kent-h deleted the bug/double-padlen branch

April 17, 2018 14:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/protocol kind/bug reviewed/looks-good-to-me reviewed/merge-on-green