Match XM Parsing - Type & Length Ignored #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h have already been read, which was not previously taken into account.
…ed in the length, per the OF 1.3.3 spec ("uint16_t length; Length of ofp_match (excluding padding)"). This bug was previously masked by another bug (see previous commit).
|
Changes due to secondary bug (which was masking the first one): Also changed the |
ybubnov
reviewed
Mar 28, 2018
ofp/match.go
Outdated
| matchlen := int(length) | ||
| rdlen := matchlen - padLen(matchlen) | ||
|
|
||
| // Subtract the length of the alread-read Type & Length fields |
|
Tests failures aren't related to the changes. |
|
@kent-h, thank you for the pull-request, I highly appreciate it! |
ybubnov
added
reviewed/looks-good-to-me
reviewed/merge-on-green
and removed
status/needs-rework
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an off-by-4-bytes issue in match xm parsing. The type and length (4 bytes) are read before the LimitReader is created, and so must be subtracted from the rdlen.