Introduce connection force write #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch defines a new function for conn type that allows to write and flush the data to the connection using a single mutex acquire. Such approach should minimize context switches between go-rounite, which in general improve performance of multi-threaded applications.
|
cc @samribeiro |
|
LGTM nit: server.go:response.Write() uses buf which is locked between multiple writers. The method is naturally memory efficient because it uses the same buffer for concurrent writes. On the other side it is less performant because multiple writers need exclusive access to the buffer to calculate the length of the payload. I don't feel strongly about this but I usually opt for performance instead of memory. Go has achieved pretty good garbage collection nowadays that I care less about it. |
samribeiro
approved these changes
Sep 29, 2017
|
Memory allocation could also take time, nevertheless I agree that we should see how to improve the performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch defines a new function for conn type that allows to write
and flush the data to the connection using a single mutex acquire.
Such approach should minimize context switches between go-routines,
which in general improves performance of multi-threaded applications.