Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1466 rely on duplicate different than 'true' for prom queries #580

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Feb 22, 2024

Description

Update operator according to netobserv/flowlogs-pipeline#602
Use not_equal filter for prometheus metrics to allow queries to work whatever eBPF merge mode is used.

Dependencies

Allows netobserv/netobserv-ebpf-agent#276 removing Duplicate field when not necessary

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau added the breaking-change This pull request has breaking changes. They should be described in PR description. label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.41%. Comparing base (f4d840b) to head (bee5fb6).

❗ Current head bee5fb6 differs from pull request most recent head 126e830. Consider uploading reports for the commit 126e830 to get more accurate results

Files Patch % Lines
controllers/flp/flp_pipeline_builder.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   67.56%   67.41%   -0.15%     
==========================================
  Files          69       69              
  Lines        8192     8182      -10     
==========================================
- Hits         5535     5516      -19     
- Misses       2317     2324       +7     
- Partials      340      342       +2     
Flag Coverage Δ
unittests 67.41% <88.88%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpinsonneau
Copy link
Contributor Author

Waiting for netobserv/flowlogs-pipeline#602 to update this

@jpinsonneau jpinsonneau removed breaking-change This pull request has breaking changes. They should be described in PR description. do-not-merge/hold labels Feb 26, 2024
@jotak
Copy link
Member

jotak commented Feb 26, 2024

/lgtm
to be merged after mine on FLP

@openshift-ci openshift-ci bot added the lgtm label Feb 26, 2024
@jpinsonneau jpinsonneau added approved breaking-change This pull request has breaking changes. They should be described in PR description. labels Feb 26, 2024
Copy link

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Feb 26, 2024
Copy link

openshift-ci bot commented Feb 26, 2024

New changes are detected. LGTM label has been removed.

@jotak
Copy link
Member

jotak commented Feb 26, 2024

@jpinsonneau I commit the FLP bump

@jotak jotak added the lgtm label Feb 26, 2024
Copy link

openshift-ci bot commented Feb 26, 2024

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator ed71b43 link false /test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak jotak merged commit c2e613b into netobserv:main Feb 26, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants