-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1466 rely on duplicate different than 'true' for prom queries #580
Conversation
d43824e
to
bee5fb6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 67.56% 67.41% -0.15%
==========================================
Files 69 69
Lines 8192 8182 -10
==========================================
- Hits 5535 5516 -19
- Misses 2317 2324 +7
- Partials 340 342 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Waiting for netobserv/flowlogs-pipeline#602 to update this |
bee5fb6
to
126e830
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
@jpinsonneau I commit the FLP bump |
@jpinsonneau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
Update operator according to netobserv/flowlogs-pipeline#602
Use
not_equal
filter for prometheus metrics to allow queries to work whatever eBPF merge mode is used.Dependencies
Allows netobserv/netobserv-ebpf-agent#276 removing
Duplicate
field when not necessaryChecklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.