-
Notifications
You must be signed in to change notification settings - Fork 31
added encode_json support plus test #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 52.23% 53.15% +0.92%
==========================================
Files 26 27 +1
Lines 1411 1426 +15
==========================================
+ Hits 737 758 +21
+ Misses 641 634 -7
- Partials 33 34 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KalmanMeth can you add documentation for this.
Actually should config.Opt.PipeLine.Encode.Type
be part of the API now ??? I think it should and than each of the encode options should be part of enum
a2b7d06
to
f669bf7
Compare
I changed the name of the files to encode_json_to_string. The input is json (configMap), but the difference is that it outputs a string for each configMap. There is no API detail needed since there are no parameters that the user needs to provide. |
f669bf7
to
5b1bec5
Compare
In light of our discussion, I changed the name back to encode_json.go. |
10765c8
to
c371113
Compare
removed default none from options
c371113
to
069ead8
Compare
No description provided.