Skip to content

Conversation

KalmanMeth
Copy link
Collaborator

No description provided.

@KalmanMeth KalmanMeth requested review from eranra and ronensc February 9, 2022 12:28
@codecov-commenter
Copy link

Codecov Report

Merging #60 (a2b7d06) into main (ada5811) will increase coverage by 0.92%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   52.23%   53.15%   +0.92%     
==========================================
  Files          26       27       +1     
  Lines        1411     1426      +15     
==========================================
+ Hits          737      758      +21     
+ Misses        641      634       -7     
- Partials       33       34       +1     
Flag Coverage Δ
unittests 53.15% <80.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/encode/encode_json.go 80.00% <80.00%> (ø)
pkg/pipeline/encode/encode.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada5811...a2b7d06. Read the comment docs.

Copy link
Collaborator

@eranra eranra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KalmanMeth can you add documentation for this.

Actually should config.Opt.PipeLine.Encode.Type be part of the API now ??? I think it should and than each of the encode options should be part of enum

@KalmanMeth
Copy link
Collaborator Author

I changed the name of the files to encode_json_to_string. The input is json (configMap), but the difference is that it outputs a string for each configMap. There is no API detail needed since there are no parameters that the user needs to provide.

@KalmanMeth
Copy link
Collaborator Author

In light of our discussion, I changed the name back to encode_json.go.
I also added a few sentences in the README to document the json encoder.

@KalmanMeth KalmanMeth merged commit 8cb43e4 into netobserv:main Feb 16, 2022
@KalmanMeth KalmanMeth deleted the encode-json branch February 16, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants