Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-934: Add icmpv4/v6 bits to FLP #408

Merged
merged 2 commits into from
Apr 26, 2023
Merged

NETOBSERV-934: Add icmpv4/v6 bits to FLP #408

merged 2 commits into from
Apr 26, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Mar 20, 2023 •
edited
Loading

netobserv/netobserv-ebpf-agent#103 added support to ICMPv4/6 and updated gRPC protobuf this PR to syncup flb repo with those changes and update the unit-test cases.

Also gRPC connect api was changed recently to fix ipv6 socket so fixed its use in pipeline_test

@msherif1234
Update netobserv pkg to latest to pickup ICMP changes
efb6b74 
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@msherif1234
update gRPC protobuf to include ICMP struct
800cb81 
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@codecov
Copy link

codecov bot commented Mar 20, 2023 •
edited
Loading

Codecov Report

Merging #408 (800cb81) into main (0269dcc) will increase coverage by 0.15%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   63.63%   63.79%   +0.15%     
==========================================
  Files          92       92              
  Lines        6471     6479       +8     
==========================================
+ Hits         4118     4133      +15     
+ Misses       2113     2106       -7     
  Partials      240      240
Flag Coverage Δ
unittests 63.79% <92.30%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/convert.go 79.05% <90.90%> (+4.46%) ⬆️
pkg/pipeline/decode/decode_protobuf.go 78.43% <100.00%> (+0.88%) ⬆️

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 20, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:8c0432f. It will expire after two weeks.

@msherif1234 msherif1234 changed the title Add icmp NETOBSERV-934: Add icmpv4/v6 bits to FLP Mar 20, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 20, 2023 •
edited by openshift-ci bot
Loading

@msherif1234: This pull request references NETOBSERV-934 which is a valid jira issue.

In response to this:

netobserv/netobserv-ebpf-agent#103 added support to ICMPv4/6 and updated gRPC protobuf this PR to syncup flb repo with those changes and update the unit-test cases.

Also gRPC connect api was changed recently to fix ipv6 socket so fixed its use in pipeline_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/ok-to-test

@jotak
Copy link
Member

jotak commented Mar 21, 2023 •
edited by msherif1234
Loading

/hold
need to coordinate with QE/doc
cc @memodi @skrthomas

@msherif1234
Copy link
Contributor Author

/hold cancel
we have released 1.2 so this can go in

jpinsonneau
jpinsonneau approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @msherif1234 👍

@openshift-ci openshift-ci bot added the lgtm label Mar 28, 2023
ronensc
ronensc approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@ronensc ronensc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotak
Copy link
Member

jotak commented Mar 30, 2023

/approve

@jotak jotak removed the approved label Mar 30, 2023
@jotak
Copy link
Member

jotak commented Mar 30, 2023

sorry - removing approval: this will be pre-merge tested, unless QE agrees for post-merge. cc @memodi (this is not for 1.2)

@memodi
Copy link

memodi commented Mar 30, 2023 •
edited
Loading

sorry - removing approval: this will be pre-merge tested, unless QE agrees for post-merge. cc @memodi (this is not for 1.2)

ack, we should prioritize this after finishing 1.2 tasks. cc @Amoghrd

@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 24, 2023

/ok-to-test

1 similar comment
@msherif1234
Copy link
Contributor Author

/ok-to-test

@msherif1234 msherif1234 removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 24, 2023
@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 24, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 24, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:1420fee. It will expire after two weeks.

@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 25, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Apr 25, 2023
@jpinsonneau
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak, jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 51f5e50 into netobserv:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@ronensc ronensc ronensc approved these changes

@KalmanMeth KalmanMeth Awaiting requested review from KalmanMeth

Assignees

@ronensc ronensc

@jpinsonneau jpinsonneau

Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@msherif1234 @openshift-ci-robot @jotak @memodi @Amoghrd @jpinsonneau @ronensc @openshift-merge-robot