NETOBSERV-584: Support for writing logs to Loki (distributor) using gRPC

[leandroberetta]

Description

Support for writing logs to Loki (distributor) using gRPC

Ref: https://issues.redhat.com/browse/NETOBSERV-584

Dependencies

netobserv/loki-client-go#3

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

To run a perfscale test, comment with: /test flp-node-density-heavy-25nodes

[codecov]

Codecov Report

❌ Patch coverage is 77.62238% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.97%. Comparing base (838c22c) to head (be97be3).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/pipeline/write/write_loki.go	68.81%	20 Missing and 9 partials ⚠️
pkg/api/write_loki.go	94.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
+ Coverage   65.67%   65.97%   +0.30%     
==========================================
  Files         121      121              
  Lines        8934     9065     +131     
==========================================
+ Hits         5867     5981     +114     
- Misses       2735     2747      +12     
- Partials      332      337       +5     

Flag	Coverage Δ
unittests	65.97% <77.62%> (+0.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/api/write_loki.go	89.88% <94.00%> (+18.45%)	⬆️
pkg/pipeline/write/write_loki.go	74.50% <68.81%> (+0.82%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

New image:
quay.io/netobserv/flowlogs-pipeline:232d236

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=232d236 make set-flp-image

[openshift-ci-robot]

@leandroberetta: This pull request references NETOBSERV-584 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

Support for writing logs to Loki (distributor) using gRPC

Ref: https://issues.redhat.com/browse/NETOBSERV-584

Dependencies

netobserv/loki-client-go#3

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

To run a perfscale test, comment with: /test flp-node-density-heavy-25nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[github-actions]

New image:
quay.io/netobserv/flowlogs-pipeline:fecd9f7

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=fecd9f7 make set-flp-image

[jpinsonneau]

Same here, we may reuse ClientConfig that contains TLSConfig ?
https://github.com/prometheus/common/blob/v0.66.1/config/http_config.go#L1113

[jotak]

Just checked that, surely that's doable, but prom's TLS config contains more advanced settings (e.g. min / max versions) which we would need to support in our implementation in the loki-client, if we want to be consistent with the proposed settings. Or we would need to reuse prom's implementation but I'm not sure they have grpc in the go-client. So perhaps having our own struct is good enough for now, after all.

[jotak]

wait, actually, we do also have another TLS struct of our own: api.ClientTLS
That one could be reused easily, no ?
/hold

[leandroberetta]

Hi, I've just seen this comment, actually, I did the work to reuse the prom's tls config. Also, I've made the necessary changes in the loki-client-go at netobserv/loki-client-go#4

@jotak the one you mentioned is used for Kafka and it seemed to be more simple than the prom one, for example, for now, communicating with the distributor in grpc mode, I need to configure mTLS which I don't see that is possible with the kafka one.

[jotak]

oh, cool, that should be even better

[jotak]

you can now remove that as this was merged

[jotak]

/lgtm
thanks @leandroberetta !

[edit] actually, last-minute comment: #1086 (comment)

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@leandroberetta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/qe-e2e-tests	d01e386	link	false	/test qe-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.