[FIX] Fix doc load_data #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems error messages have changed, making the try-except catches invalid. We should probably refactor these in the future though.
Member
|
Just as an update on what is happening here: these new error messages come from a recent PR in nibabel. Users that have the newest version of nibabel installed will get the new error message while those that have the older versions will have the older error message. Backward compatibility should be ok since the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems error messages have changed, making the try-except catches invalid.
Although not sure about if it would cause backward incompatibility, but for sufficiently new Python version it should be generally okay I guess?
We should probably refactor these in the future though.