chore(deps): update dependency @netlify/eslint-config-node to ^3.0.3 (#…

…490)

package.json

@@ -82,7 +82,7 @@
     "yargs": "^15.4.1"
   },
   "devDependencies": {
-    "@netlify/eslint-config-node": "^3.0.1",
+    "@netlify/eslint-config-node": "^3.0.3",
     "adm-zip": "^0.5.0",
     "ava": "^2.4.0",
     "cpy": "^8.0.0",

src/config.js

@@ -7,7 +7,6 @@ const getConfigForFunction = ({ config, func }) => {
   }
 
   // It's safe to mutate the array because it's local to this function.
-  // eslint-disable-next-line fp/no-mutating-methods
   const matches = Object.keys(config)
     .filter((expression) => minimatch(func.name, expression))
     .map((expression) => {

src/node_dependencies/index.js

@@ -33,7 +33,6 @@ const listFilesUsingLegacyBundler = async function ({ srcPath, mainFile, srcDir,
 
   // We sort so that the archive's checksum is deterministic.
   // Mutating is fine since `Array.filter()` returns a shallow copy
-  // eslint-disable-next-line fp/no-mutating-methods
   const filteredFiles = uniqueFiles.filter(isNotJunk).sort()
   return filteredFiles
 }

src/node_dependencies/resolve.js

@@ -61,15 +61,12 @@ const resolvePathPreserveSymlinksForDir = function (path, basedir) {
 // see https://github.com/browserify/resolve/issues/188#issuecomment-679010477
 // we return the first resolved location or the first error if all failed
 const resolvePathPreserveSymlinks = async function (path, baseDirs) {
-  // eslint-disable-next-line fp/no-let
   let firstError
-  // eslint-disable-next-line fp/no-loops
   for (const basedir of baseDirs) {
     try {
       // eslint-disable-next-line no-await-in-loop
       return await resolvePathPreserveSymlinksForDir(path, basedir)
     } catch (error) {
-      // eslint-disable-next-line fp/no-mutation
       firstError = firstError || error
     }
   }

src/runtimes/node/finder.js

@@ -24,7 +24,6 @@ const findFunctionsInPaths = async function (paths) {
   const functions = await Promise.all(paths.map(getFunctionAtPath))
 
   // It's fine to mutate the array since its scope is local to this function.
-  // eslint-disable-next-line fp/no-mutating-methods
   const sortedFunctions = functions.filter(Boolean).sort((fA, fB) => {
     // We first sort the functions array to put directories first. This is so
     // that `{name}/{name}.js` takes precedence over `{name}.js`.

src/runtimes/node/native_modules/plugin.js

@@ -12,7 +12,7 @@ const packageName = /^([^@][^/]*|@[^/]*\/[^/]+)(?:\/|$)/
 
 const findNativeModule = (packageJsonPath, cache) => {
   if (cache[packageJsonPath] === undefined) {
-    // eslint-disable-next-line fp/no-mutation, no-param-reassign, promise/prefer-await-to-then
+    // eslint-disable-next-line no-param-reassign, promise/prefer-await-to-then
     cache[packageJsonPath] = readPackageJson(packageJsonPath).then(
       (data) => [Boolean(isNativeModule(data), data), data],
       () => [],
@@ -33,10 +33,8 @@ const externalNativeModulesPlugin = (externalizedModules) => ({
 
       if (!package) return
 
-      // eslint-disable-next-line fp/no-let
       let directory = args.resolveDir
 
-      // eslint-disable-next-line fp/no-loops
       while (true) {
         if (path.basename(directory) !== 'node_modules') {
           const modulePath = path.join(directory, 'node_modules', package[1])
@@ -48,11 +46,11 @@ const externalNativeModulesPlugin = (externalizedModules) => ({
           if (isNative === true) {
             // eslint-disable-next-line max-depth
             if (externalizedModules[args.path] === undefined) {
-              // eslint-disable-next-line fp/no-mutation, no-param-reassign
+              // eslint-disable-next-line no-param-reassign
               externalizedModules[args.path] = {}
             }
 
-            // eslint-disable-next-line fp/no-mutation, no-param-reassign
+            // eslint-disable-next-line no-param-reassign
             externalizedModules[args.path][modulePath] = packageJsonData.version
 
             return { path: args.path, external: true }
@@ -70,7 +68,6 @@ const externalNativeModulesPlugin = (externalizedModules) => ({
           break
         }
 
-        // eslint-disable-next-line fp/no-mutation
         directory = parentDirectory
       }
     })

tests/fixtures/node-module-dynamic-import-invalid/function.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-extraneous-dependencies
 module.exports = require('@org/test')