Skip to content
This repository was archived by the owner on Sep 12, 2019. It is now read-only.

gracefully handle bad function responses #124

Merged
merged 2 commits into from
Apr 16, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/utils/serve-functions.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,20 @@ function createCallback(response) {
if (err) {
return handleErr(err, response);
}
if (!Number(lambdaResponse.statusCode)) {
console.log(
`${NETLIFYDEVERR} Your function response must have a numerical statusCode. You gave: $`,
lambdaResponse.statusCode
);
return handleErr("Incorrect function response statusCode", response);
}
if (typeof lambdaResponse.body !== "string") {
console.log(
`${NETLIFYDEVERR} Your function response must have a string body. You gave:`,
lambdaResponse.body
);
return handleErr("Incorrect function response body", response);
}

response.statusCode = lambdaResponse.statusCode;
// eslint-disable-line guard-for-in
Expand Down