This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
We have some code that handles the case where the API returns
429
but noX-RateLimit-Reset
response header.The current code does not work since
Number.parseInt()
returns either an integer orNaN
andexisty()
checks== null
, i.e. that code is unreachable.- Test plan
A test was added as part of #68.
- Description for the changelog
Fix rate limiting bug.