Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Improve OpenAPI logic #66

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Improve OpenAPI logic #66

merged 1 commit into from
Oct 4, 2019

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Sep 11, 2019

- Summary

This improves the OpenAPI logic:

  • simplify the code
  • do not directly mutate the OpenAPI definition exported by @netlify/open-api. We currently do it, which will cause bugs if the users are requiring @netlify/open-api in a different file.
  • remove parameter.index (it is not used)

This also renames the following words to follow the official OpenAPI lingo:

  • "method" renamed to "operation". This also avoids confusion with class methods and HTTP methods.
  • "verb" renamed to "HTTP method".
  • this was done only in the README and internal variables. The exported variables/properties are still called method and verb to avoid breaking changes.

- Description for the changelog

Improves the OpenAPI logic.

@ehmicky ehmicky force-pushed the feature/improve-open-api-logic branch 2 times, most recently from 1eea0ca to 713caff Compare September 11, 2019 12:03
@coveralls
Copy link

coveralls commented Sep 11, 2019

Coverage Status

Coverage decreased (-0.8%) to 65.69% when pulling 600b02a on feature/improve-open-api-logic into 3d40ef4 on master.

@ehmicky ehmicky force-pushed the feature/improve-open-api-logic branch 3 times, most recently from 6b6ae63 to 600b02a Compare September 11, 2019 12:06
@ehmicky ehmicky requested review from DavidWells and keiko713 and removed request for keiko713 September 16, 2019 12:03
@ehmicky ehmicky force-pushed the feature/improve-open-api-logic branch 2 times, most recently from 597825d to 917f875 Compare October 4, 2019 11:54
@ehmicky ehmicky force-pushed the feature/improve-open-api-logic branch from 917f875 to be3ce94 Compare October 4, 2019 12:22
@ehmicky ehmicky merged commit 8d4b3d8 into master Oct 4, 2019
@ehmicky ehmicky deleted the feature/improve-open-api-logic branch October 4, 2019 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants