This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
Enable fp/no-class ESLint rule
#251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Dec 18, 2020
| @@ -5,6 +5,7 @@ const deploy = require('./deploy') | |||
| const { getMethods } = require('./methods') | |||
| const { getOperations } = require('./operations') | |||
|
|
|||
| // eslint-disable-next-line fp/no-class | |||
There was a problem hiding this comment.
Removing the class would be a major breaking change with little benefit.
ehmicky
force-pushed
the
lint/no-class
branch
from
ac0c171
to
809b6ac
Compare
erezrokah
approved these changes
Dec 20, 2020
erezrokah
force-pushed
the
lint/no-class
branch
from
f925c75
to
e332ff9
Compare
erezrokah
approved these changes
Dec 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
fp/no-classESLint rule.