Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing export for Prettier configuration #439

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Feb 2, 2022

When using the exports field in package.json, it becomes forbidden to import files that are not explicitly declared as exported.
We have just added that field but we forgot to declare .prettierrc.json as exported, since consumers import it.
This is making CI tests of consumers of @netlify/eslint-config-node fail (example).

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Feb 2, 2022
@ehmicky ehmicky self-assigned this Feb 2, 2022
@ehmicky ehmicky merged commit 1b152a9 into main Feb 2, 2022
@ehmicky ehmicky deleted the fix/prettier-export branch February 2, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants