Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove broken duplicate rule #427

Merged
merged 1 commit into from
Jan 21, 2022
Merged

fix: remove broken duplicate rule #427

merged 1 commit into from
Jan 21, 2022

Conversation

ascorbic
Copy link
Contributor

This PR removes the rule no-duplicate-imports. It attempts to do the same as import/no-duplicates, but it does not understand TypeScript's need to have separate imports for import type {... and import {...

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 21, 2022
@kodiakhq kodiakhq bot merged commit 3fa84d5 into main Jan 21, 2022
@kodiakhq kodiakhq bot deleted the mk/no-duplicates branch January 21, 2022 13:40
@token-generator-app token-generator-app bot mentioned this pull request Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @erezrokah