Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pre-commit hook #414

Merged
merged 2 commits into from
Jan 12, 2022
Merged

chore: remove pre-commit hook #414

merged 2 commits into from
Jan 12, 2022

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jan 12, 2022

We currently enforce the following Git hooks:

  • commitlint on new commit messages
  • Linting/Prettier on git push

#403 added a new Git hook: npm test on new commits.

While this is good for code quality, I believe this might not work since some of our repositories have some pretty big test suites. Running those on each commit, as opposed to each git push might slow us down.

This PR reverts this new Git hook. Please let me know what you think!

cc @XhmikosR

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Jan 12, 2022
@ehmicky ehmicky self-assigned this Jan 12, 2022
@ehmicky ehmicky merged commit 98952b0 into main Jan 12, 2022
@ehmicky ehmicky deleted the chore/remove-pre-commit-hook branch January 12, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants