Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable prefer-node-protocol #171

Merged
merged 2 commits into from
Apr 26, 2021
Merged

fix: disable prefer-node-protocol #171

merged 2 commits into from
Apr 26, 2021

Conversation

erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Apr 26, 2021 •
edited
Loading

no-unresolved and no-missing-import don't recognize the node protocol yet (e.g they error on node:buffer).

Related to netlify/gotrue-js#345

@erezrokah erezrokah requested a review from ehmicky April 26, 2021 11:33
@erezrokah erezrokah enabled auto-merge (squash) April 26, 2021 11:33
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Apr 26, 2021
@erezrokah erezrokah merged commit d5b8fd9 into main Apr 26, 2021
@erezrokah erezrokah deleted the fix/disable_prefer-node-protocol branch April 26, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @ehmicky