Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert dev command to clack #6366

Conversation

lemusthelroy
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Converts dev command to Clack. This is a difficult command to test as there is a lot of different routes to cover, based on what type of project the dev command is being run on. I have tested, and include screenshots below, for the following scenarios:

Static site (with edge function):
image

Astro site:
image

Next site:
image

For reference, this is what this command looked like previously:
image

What this PR does not include

  • A more comprehensive check on other dev scenarios
  • We have an ongoing discussion on the impact of removing the boxen that present the server as being ready. We know this is a visual cue for many users so want to make sure we get this right.

Other notes to reviewers

  • We use some libraries, including @netlify/build that log out messages that break the clack styling which is why I have opted to transport any console.log into NetlifyLog. This is worth taking some time to review but I think it is necessary.

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lemusthelroy lemusthelroy requested a review from a team as a code owner February 1, 2024 12:13
@lemusthelroy lemusthelroy changed the title chore: wip convert dev command and stream logs into NetlifyLog - need… chore: convert dev command to clack Feb 1, 2024
@lemusthelroy
Copy link
Contributor Author

Going to have to revisit this PR due to the snapshot tests on the framework detection tests

@lemusthelroy
Copy link
Contributor Author

I ran into issues with this branch locally when trying to switch user. Will investigate further.

@lemusthelroy lemusthelroy merged commit 3f7e207 into CP-101/design-system-clack-implementation Mar 19, 2024
32 of 34 checks passed
@lemusthelroy lemusthelroy deleted the CP-101/convert-dev-command branch March 19, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants