fix: determine duplicate function precedence based on extension #5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 219dd3c Package size: 313 MB⬇️ 0.00% decrease vs. 219dd3c Legend
|
|
I will! |
danez
suggested changes
Apr 12, 2023
khendrikse
force-pushed
the
feat-461/set-function-precedence-based-on-extension
branch
from
3684235
to
c5a759a
Compare
danez
previously approved these changes
Apr 12, 2023
danez
reviewed
Apr 12, 2023
| @@ -212,7 +212,8 @@ export class FunctionsRegistry { | |||
| await Promise.all(deletedFunctions.map((func) => this.unregisterFunction(func.name))) | |||
|
|
|||
| await Promise.all( | |||
| functions.map(async ({ displayName, mainFile, name, runtime: runtimeName }) => { | |||
| // We reverse the array so we get the right functions precedence | |||
| functions.reverse().map(async ({ displayName, mainFile, name, runtime: runtimeName }) => { | |||
There was a problem hiding this comment.
how does this solve the problem? Can you describe how this works?
There was a problem hiding this comment.
Sure! I added an extra comment now :) zip-it-and-ship-it returns an array with the last functions preceding the previous. But we need to reverse that in the cli
danez
approved these changes
Apr 12, 2023
| @@ -212,7 +212,8 @@ export class FunctionsRegistry { | |||
| await Promise.all(deletedFunctions.map((func) => this.unregisterFunction(func.name))) | |||
|
|
|||
| await Promise.all( | |||
| functions.map(async ({ displayName, mainFile, name, runtime: runtimeName }) => { | |||
| // We reverse the array so we get the right functions precedence | |||
| functions.reverse().map(async ({ displayName, mainFile, name, runtime: runtimeName }) => { | |||
kodiakhq
bot
deleted the
feat-461/set-function-precedence-based-on-extension
branch
|
This broke some tests I think. |
I'm really confused as to how I was able to merge this PR :/ |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/pod-compute/issues/462
Right now, the cli doesn't behave the same as production when it comes to duplicate function precedence. This should fix it. For more detail check the issue1
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)