test(command-dev): log dev server output on timeout #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
added
the
type: chore
ehmicky
reviewed
Jan 5, 2021
tests/utils/dev-server.js
Outdated
| @@ -63,6 +66,9 @@ const startServer = async ({ cwd, env = {}, args = [] }) => { | |||
| }) | |||
| ps.catch((error) => !selfKilled && reject(error)) | |||
| }) | |||
|
|
|||
| const { timeout, ...server } = await Promise.race([serverPromise, getTimeoutPromise(SERVER_START_TIMEOUT)]) | |||
There was a problem hiding this comment.
[sand] Do you think p-timeout might help with this pattern?
https://github.com/sindresorhus/p-timeout
ehmicky
reviewed
Jan 5, 2021
tests/utils/dev-server.js
Outdated
| ps.stdout.on('data', (data) => { | ||
| if (data.toString().includes('Server now ready on')) { | ||
| ps.stdout.on('data', (dataBuffer) => { | ||
| const data = dataBuffer.toString() |
There was a problem hiding this comment.
I believe using the encoding: 'utf-8' option of execa should provide with data string chunks instead directly. Would this work?
There was a problem hiding this comment.
Sure, done in a0d8158
ehmicky
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reports the dev server output in our tests when we fail to spawn it.