Sync hotfix stable #1656
Merged
Sync hotfix stable #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: cloud recording function is not working now, this commit only tweaks UI
crimx
approved these changes
Aug 24, 2022
crimx
pushed a commit
that referenced
this pull request
Aug 24, 2022
* fix(classroom): add loading state to cloud record button (#1628) Note: cloud recording function is not working now, this commit only tweaks UI * fix(whiteboard): typo (this component will be removed entirely in the future) * refactor(whiteboard): add extra insert image option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included in this PR:
cheery-pick fix(classroom): add loading state to cloud record button #1628, add loading state to cloud record button.
However, cloud recording has not been implemented in main branch, so this commit only tweaks UI.
cheery-pick refactor(whiteboard): change to selector once insert image #1629, but add an extra option to fastboard service.
TODO:
Implement cloud recording properly, which requires @BlackHole1 and @crimx to work it out. Refer to refactor(whiteboard): change to selector once insert image #1629 and refactor(classroom): make cloud recording more stable #1634 for more details.
Implement the whiteboard component (should be in fastboard service) properly, it includes functions like drag-and-drop. Refer to Whiteboard.tsx for more details.