feat: add let's encrypt toggle; various fixes #110
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Let's Encrypt certificate request functionality to the Settings page and implements various fixes to improve the user interface and error handling. The changes primarily focus on refactoring the settings form to support certificate management, improving field validation, and better handling of network interface configuration.
Key changes:
- Added Let's Encrypt toggle with warning notifications for certificate management
- Refactored interface/address handling with improved validation and error messages
- Enhanced UI with loading states, better field organization, and inline notifications for validation errors
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui/src/views/Settings.vue | Added Let's Encrypt toggle, refactored interface/address fields, improved validation and error handling, added status API call |
| ui/src/App.vue | Added utility CSS classes for positioning and margins |
| ui/public/i18n/en/translation.json | Updated translation keys for new interface/address fields and removed deprecated warning section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andre8244
force-pushed
the
add-letsencrypt-toggle
branch
from
993b7fa to
3814230
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
ui/public/i18n/en/translation.json:1
- Corrected spelling of 'errore' to 'error'.
{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andre8244
force-pushed
the
add-letsencrypt-toggle
branch
from
3814230 to
24dd3aa
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
andre8244
force-pushed
the
add-letsencrypt-toggle
branch
from
37b64c5 to
971341b
Compare
Ref: