Fix remaining TODO's from GitHub Actions build-and-release workflow PR + cleanup autotools generated files with gitignore #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the broken status badge after an earlier PR was merged too early. nethappen#14
Fix up an issue where only the DEB package was being uploaded, due to a variable being set in the wrong place. nethappen#14
Fixes the untested tag detection logic after an earlier PR was merged too early. nethappen#14
Tweak the artifact retention times, and accept that an error (due to storage quota) should not be considered fatal. nethappen#14
Uses the '.gitignore' file to ignore the autotools generated files [1], and also remove the generated files which are tracked by git. Updates the "README.md" so the user runs the 'autoreconf' on each system. It's best practice to avoid keeping code-gen files tracked by git, and importantly it enables cleaner builds (by making 'git clean' commands work as expected). [1] https://stackoverflow.com/a/16404209 [2] https://stackoverflow.com/questions/46273032/is-there-a-way-to-remove-all-ignored-files-from-a-local-git-working-tree#comment128882666_46273197
Contributor
Author
|
Once this PR is merged, I recommend creating a new git tag and pushing it. Following your existing tag style Because that will create a new GitHub release (using GitHub Actions infrastructure), making a prebuilt deb and (Linux) binary available for anybody who wants it. Here's an example from the GitHub fork I tried this on: [1] https://github.com/rescuezilla/blocksync-fast/actions/runs/17014821212 [2] https://github.com/rescuezilla/blocksync-fast/releases/tag/v1.0.7.1-0-g9563053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in prior PR #14, there were some TODO's that needed to be fixed before merging.
Unfortunately the PR was merged regardless, so pushing the fixes to these things (as 4 atomic commits)
Unrelatedly, expands
.gitignorefile and removes the generated files so thatgit cleancommands work.