Skip to content

[NAE-1867] Fulltext replaces only first ' ' #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023
Merged

[NAE-1867] Fulltext replaces only first ' ' #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/netgrif-components-core/src/lib/search/models/operator/substring.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class Substring extends Operator<string> {
// TODO IMPROVEMENT 27.4.2020 - we could use regular expressions to search for substrings which would solve the unintuitive
// behavior that occurs when we search for strings that contain spaces. We need to escape the input string in a special way
// if we choose to do this
const escapedValue = Operator.escapeInput(args[0]).value.replace(' ', '\\ ');
const escapedValue = Operator.escapeInput(args[0]).value.replace(/ /g, '\\ ');
return Operator.forEachKeyword(elasticKeywords, keyword => new Query(`(${keyword}:*${escapedValue}*)`));
}

Expand Down
2 changes: 1 addition & 1 deletion projects/netgrif-components-core/src/lib/search/search-service/search.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export class SearchService implements OnDestroy {
* @param searchedSubstring value that should be searched on all full text fields
*/
public setFullTextFilter(searchedSubstring: string): void {
const whiteSpacedSubstring = searchedSubstring.replace(' ', '\\ ');
const whiteSpacedSubstring = searchedSubstring.replace(/ /g, '\\ ');
this._fullTextFilter = new SimpleFilter('', this._baseFilter.type, {fullText: whiteSpacedSubstring});
this.updateActiveFilter();
}
Expand Down