[NAE-1703] Dashboard #120

mazarijuraj · 2022-09-29T13:03:24Z

Description

Configurable dashboard and dashboard tile processes

Implements NAE-1703

How Has Been This Tested?

Manually

Checklist:

- Empty Task ref component classes

- Don't filter out dashboard task ref fields when preprocessing data groups

- associate dashboard tiles with dashboard task ref field

- component resolver task ref field

- resolve dashboard rows/cols

- fix resolve dashboard rows/cols

- layout task ref dashboard grid tiles

- fix dashboard group title line present

- fix dashboard group lost layout information

- task ref dashboard tile content resolution

- fix task ref dashboard tile task content spinner

- task ref dashboard tile + button

- create task ref dashboard tile case on +

- task ref dashboard tile + is shown only if the task ref is editable and not blocked (assigned)

- create new task ref dashboard tile case instance and set relevant tile data

- set new task ref dashboard tile reference in the parent task ref - fixed diagonal swap of dashboard + button positions

- change button type - add border

- hidden fields in data groups are filtered only in the data groups that are immediately displayed (dashboard content is passed unfiltered until it reaches the display stage)

- dashboard line chart text field component prototype/example

- display the chart component as a text area when editable

- fix empty dashboard bugs - add parent case id data when creating dashboard tile

- add pie chart component

- add portal card component

- add portal component registry service

- add bar chart component

- add iframe dashboard component

- register multiple example app components to dashboard registry - add injector as component getter argument

- refresh content of task, when new tile is added by clicking +

- implemented abstract classes for filter components - implemented tests for abstract classes for filter components - added type resolution to dashboard-portal-component-registry.service.ts - implemented dashboard constants enum - reverted old method of implementing components for filter case, now using portals

- corrected tests

# Conflicts: # projects/netgrif-components-core/src/lib/data-fields/public-api.ts

- added resolution for grid, when col number is greater than 1 for tile

# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json

sonarqubecloud · 2022-10-20T12:47:11Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

40.7% Coverage
0.0% Duplication

projects/netgrif-components-core/src/lib/data-fields/text-field/models/text-field.ts

# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json

sonarqubecloud · 2022-12-20T09:07:52Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

40.7% Coverage
0.0% Duplication

renczesstefan · 2023-01-17T10:04:51Z

projects/nae-example-app/src/app/app.module.ts

    ],
    bootstrap: [AppComponent]
 })
 export class AppModule {
+
+    constructor(registry: DashboardPortalComponentRegistryService) {
+        registry.register('email', (injector: Injector) => new ComponentPortal(EmailSubmissionFormComponent, null, injector));


I think it would be better to replace these string literals with constants.

renczesstefan · 2023-01-17T10:07:22Z

projects/nae-example-app/src/app/doc/dashboard-case-example/dashboard-case-example.component.ts

+    public tabs = [];
+
+    constructor(public userService: UserService) {
+        const filter = SimpleFilter.fromCaseQuery({process: {identifier: 'dashboard'}}).merge(


Why are you using .merge? It is possible to define author and process in the same query, isn't it?

renczesstefan · 2023-01-17T10:13:14Z

projects/netgrif-components-core/src/lib/panel/task-panel/abstract-task-panel.component.ts

@@ -320,7 +326,7 @@ export abstract class AbstractTaskPanelComponent extends AbstractPanelWithImmedi
    }

    public canCollapse(): boolean {
-        return this._permissionService.canCollapse(this.taskPanelData.task);
+        return this._taskForceOpen ? false : this._permissionService.canCollapse(this.taskPanelData.task);


How does this force open work? If it is set to true, it is not possible to close the task?

- corrected text area.

sonarqubecloud · 2023-02-06T09:31:10Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

40.6% Coverage
0.0% Duplication

- corrected bug, when fields are in wrong order, because hidden task ref is present in datagroup array

# Conflicts: # CHANGELOG.md # package.json # projects/nae-example-app/src/app/app.module.ts # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json # projects/netgrif-components/src/lib/data-fields/data-fields.module.ts # projects/netgrif-components/src/lib/panel/panel.module.ts

pull-request-quantifier-deprecated · 2023-05-05T08:25:52Z

This PR has 2574 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +2423 -151
Percentile : 100%

Total files changed: 122

Change summary by file extension:
.md : +1 -0
.json : +12 -4
.ts : +2130 -127
.html : +152 -19
.scss : +128 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

sonarqubecloud · 2023-05-05T08:39:12Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
17 Code Smells

39.9% Coverage
0.0% Duplication

minop and others added 30 commits September 7, 2022 12:59

[NAE-1704] Dashboard data field component

7af984b

- Empty Task ref component classes

[NAE-1704] Dashboard data field component

eceb7ec

- Don't filter out dashboard task ref fields when preprocessing data groups

[NAE-1704] Dashboard data field component

d1a6063

- associate dashboard tiles with dashboard task ref field

[NAE-1704] Dashboard data field component

10f6b1e

- component resolver task ref field

[NAE-1704] Dashboard data field component

ec2d72c

- resolve dashboard rows/cols

[NAE-1704] Dashboard data field component

828c472

- fix resolve dashboard rows/cols

[NAE-1704] Dashboard data field component

c8d09f8

- layout task ref dashboard grid tiles

[NAE-1704] Dashboard data field component

30256c2

- fix dashboard group title line present

[NAE-1704] Dashboard data field component

2aaed33

- fix dashboard group lost layout information

[NAE-1704] Dashboard data field component

6da15d3

- task ref dashboard tile content resolution

[NAE-1704] Dashboard data field component

f94ef37

- fix task ref dashboard tile task content spinner

[NAE-1704] Dashboard data field component

3c0821d

- task ref dashboard tile + button

[NAE-1704] Dashboard data field component

e137a86

- create task ref dashboard tile case on +

[NAE-1704] Dashboard data field component

370aafb

- task ref dashboard tile + is shown only if the task ref is editable and not blocked (assigned)

[NAE-1704] Dashboard data field component

c95484d

- create new task ref dashboard tile case instance and set relevant tile data

[NAE-1704] Dashboard data field component

03981f3

- set new task ref dashboard tile reference in the parent task ref - fixed diagonal swap of dashboard + button positions

[NAE-1704] Dashboard data field component

c2a187a

- change button type - add border

[NAE-1704] Dashboard data field component

8b860bd

- hidden fields in data groups are filtered only in the data groups that are immediately displayed (dashboard content is passed unfiltered until it reaches the display stage)

Merge remote-tracking branch 'origin/NAE-1704' into NAE-1704

dfd8d5f

[NAE-1711] Dashboard tile content component

2e2496b

- dashboard line chart text field component prototype/example

[NAE-1711] Dashboard tile content component

8b07963

- display the chart component as a text area when editable

[NAE-1704] Dashboard data field component

5d9741b

- fix empty dashboard bugs - add parent case id data when creating dashboard tile

Merge branch 'NAE-1704' into NAE-1711

84bd5f5

[NAE-1711] Dashboard tile content component

462caef

- add pie chart component

[NAE-1711] Dashboard tile content component

ee1457e

- add portal card component

[NAE-1711] Dashboard tile content component

960c639

- add portal component registry service

[NAE-1711] Dashboard tile content component

f42a15e

- add bar chart component

[NAE-1711] Dashboard tile content component

0f051d7

- add iframe dashboard component

[NAE-1711] Dashboard tile content component

71ce1f5

- register multiple example app components to dashboard registry - add injector as component getter argument

[NAE-1711] Dashboard tile content component

5cdb90f

- refresh content of task, when new tile is added by clicking +

renczesstefan dismissed minop’s stale review via 998c14f October 7, 2022 11:57

machacjozef added 3 commits October 7, 2022 14:14

Release 6.3.0-beta.1

854d004

Release 6.3.0-beta.1

268ca70

Release 6.3.0-beta.1

d956e29

machacjozef previously approved these changes Oct 7, 2022

View reviewed changes

renczesstefan dismissed machacjozef’s stale review via af8867b October 12, 2022 09:53

renczesstefan and others added 5 commits October 12, 2022 12:09

[NAE-1711] Dashboard

c119a96

- corrected tests

Merge remote-tracking branch 'origin/release/6.3.0' into NAE-1711

e3e2b10

Merge remote-tracking branch 'origin/release/6.3.0' into NAE-1711

8f2aeeb

# Conflicts: # projects/netgrif-components-core/src/lib/data-fields/public-api.ts

[NAE-1711] Dashboard

5c186c3

- added resolution for grid, when col number is greater than 1 for tile

Merge remote-tracking branch 'origin/release/6.3.0' into NAE-1711

e2692bd

# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json

machacjozef requested changes Oct 24, 2022

View reviewed changes

projects/netgrif-components-core/src/lib/data-fields/text-field/models/text-field.ts Outdated Show resolved Hide resolved

machacjozef and others added 3 commits December 19, 2022 18:15

Merge remote-tracking branch 'origin/release/6.3.0' into NAE-1711

16b659c

# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json

Release 6.3.0-beta.4

32c6984

Merge branch 'release/6.3.0' into NAE-1711

c85578a

renczesstefan reviewed Jan 17, 2023

View reviewed changes

[NAE-1703] Dashboard

0ee1cfc

- corrected text area.

mazarijuraj assigned minop and camperko and unassigned mazarijuraj Feb 3, 2023

renczesstefan and others added 2 commits April 20, 2023 14:08

[NAE-1871] Fields change its position in task

c9ad4bd

- corrected bug, when fields are in wrong order, because hidden task ref is present in datagroup array

mazarijuraj merged commit 70cc52a into release/6.3.0 May 5, 2023

mazarijuraj deleted the NAE-1711 branch May 5, 2023 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[NAE-1703] Dashboard #120

[NAE-1703] Dashboard #120

Uh oh!

mazarijuraj commented Sep 29, 2022 •

edited by jira bot

Loading

Uh oh!

sonarqubecloud bot commented Oct 20, 2022

Uh oh!

Uh oh!

sonarqubecloud bot commented Dec 20, 2022

Uh oh!

renczesstefan Jan 17, 2023

Uh oh!

renczesstefan Jan 17, 2023

Uh oh!

renczesstefan Jan 17, 2023

Uh oh!

sonarqubecloud bot commented Feb 6, 2023

Uh oh!

pull-request-quantifier-deprecated bot commented May 5, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

sonarqubecloud bot commented May 5, 2023

Uh oh!

Uh oh!

[NAE-1703] Dashboard #120

[NAE-1703] Dashboard #120

Uh oh!

Conversation

mazarijuraj commented Sep 29, 2022 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has Been This Tested?

Checklist:

Uh oh!

sonarqubecloud bot commented Oct 20, 2022

Uh oh!

Uh oh!

sonarqubecloud bot commented Dec 20, 2022

Uh oh!

renczesstefan Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

renczesstefan Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

renczesstefan Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 6, 2023

Uh oh!

pull-request-quantifier-deprecated bot commented May 5, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

sonarqubecloud bot commented May 5, 2023

Uh oh!

Uh oh!

mazarijuraj commented Sep 29, 2022 •

edited by jira bot

Loading