fix: Correctly throws final error when connection fails. (livekit#214)

* fix: Correctly throws final error when connection fails. * update. * update.
netgfx · Dec 5, 2022 · 833fd65 · 833fd65
1 parent 06783ca
commit 833fd65
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/lib/src/core/signal_client.dart b/lib/src/core/signal_client.dart
@@ -90,6 +90,7 @@ class SignalClient extends Disposable with EventsEmittable<SignalEvent> {
       _updateConnectionState(ConnectionState.connected);
     } catch (socketError) {
       // Attempt Validation
+      var finalError = socketError;
       try {
         // Skip validation if reconnect mode
         if (reconnect) rethrow;
@@ -106,17 +107,15 @@ class SignalClient extends Disposable with EventsEmittable<SignalEvent> {
 
         final validateResponse = await http.get(validateUri);
         if (validateResponse.statusCode != 200) {
-          throw ConnectException(validateResponse.body);
+          finalError = ConnectException(validateResponse.body);
         }
-        throw ConnectException();
       } catch (error) {
-        // Pass it up if it's already a `ConnectError`
-        if (error is ConnectException) rethrow;
-        // HTTP doesn't work either
-        throw ConnectException();
+        if (socketError.runtimeType != error.runtimeType) {
+          finalError = error;
+        }
       } finally {
         _updateConnectionState(ConnectionState.disconnected);
-        rethrow;
+        throw finalError;
       }
     }
   }

diff --git a/lib/src/exceptions.dart b/lib/src/exceptions.dart
@@ -4,7 +4,7 @@ abstract class LiveKitException implements Exception {
   const LiveKitException._(this.message);
 
   @override
-  String toString() => 'LiveKit Exception $runtimeType $message';
+  String toString() => 'LiveKit Exception: [$runtimeType] $message';
 }
 
 /// An exception occured while attempting to connect.