Release v5.8.18 fix network-groups last page - #36
Merged
Conversation
add type definitions for terminators, configs, config-types
Contributor
Author
|
This works around the API bug (won't fix) where the last page of network groups is never fetched thereby preventing any operation that needs a group from that page. |
qrkourier
commented
Apr 18, 2022
| network_group = NetworkGroup( | ||
| organization, | ||
| group=group if group else None, | ||
| group=group, |
Contributor
Author
There was a problem hiding this comment.
This was removed because the default value is already None and so the if/else flow was superfluous.
qrkourier
commented
Apr 18, 2022
| # then yield subsequent pages, if applicable | ||
| if get_all_pages: # this is False if param 'page' or 'size' to stop recursion or get a single page | ||
| for next_page in range(1, total_pages): # first page is 0 | ||
| if get_all_pages: # this is False if param 'page' or 'size' to stop recursion or get a single page |
Contributor
Author
There was a problem hiding this comment.
At this point in the generator function utility.find_generic_resources() we've already gotten the first page and decided to loop over the remaining pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.