diskspace/diskstats: don't create runtime disk config by default #16503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyam8
force-pushed
the
diskspace-diskstats-no-runtime-config
branch
from
bf6253f
to
4dcb1de
Compare
github-actions
bot
added
area/collectors
underhood
approved these changes
Nov 29, 2023
stelfrag
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR by default removes the creation of block devices and mount points configuration sections at runtime. If the section is added manually, all configuration options will be applied.
Test Plan
diskstats:
[ plugin:proc:/proc/diskstats:*]in/netdata.conf- shouldn't exist.[ plugin:proc:/proc/diskstats:*]and set any block device option innetdata.conf- should be applied.diskspace:
[plugin:proc:diskspace:*]in/netdata.conf- shouldn't exist.[plugin:proc:diskspace:*]and set any mount point option innetdata.conf- should be applied.Additional Information
For users: How does this change affect me?