Skip to content

Secrets Manager Polling #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2025
Merged

Conversation

leoparente
Copy link
Contributor

This pull request involves significant changes focused on removing the secretsmgr dependency from the configmgr package and enhancing the secretsmgr package functionality. The most important changes include updating the New function signatures, modifying the PolicyManager to handle secrets, and adding a polling mechanism for secrets in the vaultManager.

Removal of secretsmgr dependency from configmgr:

Enhancements to secretsmgr:

Modifications to PolicyManager:

  • agent/policymgr/manager.go: Updated the PolicyManager to include the secretsmgr and handle secrets within policy management. Added a callback for policy changes and updated the ManagePolicy method to solve secrets. [1] [2] [3] [4]

These changes streamline the configuration management process by decoupling the secrets management and enhancing the handling of secrets within the PolicyManager.

@leoparente leoparente self-assigned this Mar 28, 2025
Copy link

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.03s github.com/netboxlabs/orb-agent/agent 0.0% 1 0 0
🟢 PASS 0.02s github.com/netboxlabs/orb-agent/agent/backend 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/otel 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/worker 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/configmgr 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policies 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policymgr 0.0% 0 0 0
🟢 PASS 1.73s github.com/netboxlabs/orb-agent/agent/secretsmgr 6.5% 7 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 1.8%

@leoparente leoparente marked this pull request as ready for review March 28, 2025 15:25
@leoparente leoparente merged commit a21bca8 into develop Mar 29, 2025
5 checks passed
@leoparente leoparente deleted the feat/OBS-832-secrets-manager-polling branch March 29, 2025 00:00
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants