Skip to content

chore: remove cloud config deprecated code #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

leoparente
Copy link
Contributor

This pull request includes several changes to the agent/config package, primarily focusing on removing the cloud configuration manager and updating type definitions. The most important changes are summarized below:

Removal of Cloud Configuration Manager:

  • agent/configmgr/cloud.go: Entire file removed, which included the cloudConfigManager class and its associated methods for handling cloud configurations.
  • agent/configmgr/manager.go: Removed the case for creating a cloudConfigManager instance in the New function.

Type Definition Updates:

  • agent/config/types.go: Updated the PolicyPayload struct to use any instead of interface{} for the Data field.
  • agent/config/types.go: Updated the OrbAgent struct to use any instead of interface{} for the Backends and Policies fields.
  • agent/config/types.go: Removed the CloudManager struct and its associated fields from the ManagerSources struct.

Copy link

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.03s github.com/netboxlabs/orb-agent/agent 0.0% 1 0 0
🟢 PASS 0.35s github.com/netboxlabs/orb-agent/agent/backend 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/otel 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/worker 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/configmgr 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/policies 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policymgr 0.0% 0 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 0.9%

@leoparente leoparente merged commit 2baf95f into develop Mar 20, 2025
5 checks passed
@leoparente leoparente deleted the chore/remove-cloud-config branch March 20, 2025 17:39
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants