Skip to content

chore: remove mqtt dependency #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

chore: remove mqtt dependency #68

merged 1 commit into from
Mar 6, 2025

Conversation

leoparente
Copy link
Contributor

This pull request focuses on removing the dependency on the paho.mqtt.golang library from the agent package and its related backends. The changes involve cleaning up the codebase by eliminating MQTT client references and associated configurations.

Key changes include:

Removal of MQTT Dependency:

  • agent/agent.go: Removed the import of paho.mqtt.golang and references to the MQTT client and related configurations. This includes removing the MQTT client initialization, logging configurations, and cleanup during agent stop. [1] [2] [3] [4] [5] [6] [7]

  • agent/backend/backend.go: Removed the import of paho.mqtt.golang and the SetCommsClient method from the Backend interface. [1] [2]

Backend-Specific Changes:

Other Changes:

  • agent/logging.go: Removed the file entirely as it contained MQTT-specific logging implementations.

  • go.mod: Removed the dependency on paho.mqtt.golang from the module requirements. [1] [2]

@leoparente leoparente self-assigned this Feb 28, 2025
Copy link

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.02s github.com/netboxlabs/orb-agent/agent 0.0% 1 0 0
🟢 PASS 0.20s github.com/netboxlabs/orb-agent/agent/backend 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/otel 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/worker 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/configmgr 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policies 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policymgr 0.0% 0 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 0.8%

@leoparente leoparente merged commit 371a08a into develop Mar 6, 2025
5 checks passed
@leoparente leoparente deleted the chore/remove-mqtt branch March 6, 2025 12:38
Copy link

github-actions bot commented Mar 7, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants