Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on removing the dependency on the
paho.mqtt.golang
library from theagent
package and its related backends. The changes involve cleaning up the codebase by eliminating MQTT client references and associated configurations.Key changes include:
Removal of MQTT Dependency:
agent/agent.go
: Removed the import ofpaho.mqtt.golang
and references to the MQTT client and related configurations. This includes removing the MQTT client initialization, logging configurations, and cleanup during agent stop. [1] [2] [3] [4] [5] [6] [7]agent/backend/backend.go
: Removed the import ofpaho.mqtt.golang
and theSetCommsClient
method from theBackend
interface. [1] [2]Backend-Specific Changes:
agent/backend/devicediscovery/device_discovery.go
: Removed the import ofpaho.mqtt.golang
and themqttClient
field along with theSetCommsClient
method. [1] [2] [3]agent/backend/networkdiscovery/network_discovery.go
: Removed the import ofpaho.mqtt.golang
and themqttClient
field along with theSetCommsClient
method. [1] [2] [3]agent/backend/otel/otel.go
: Removed the import ofpaho.mqtt.golang
and themqttClient
field along with theSetCommsClient
method. [1] [2] [3]agent/backend/pktvisor/pktvisor.go
: Removed the import ofpaho.mqtt.golang
, themqttClient
field, and theSetCommsClient
method. [1] [2] [3]agent/backend/worker/worker.go
: Removed the import ofpaho.mqtt.golang
and themqttClient
field along with theSetCommsClient
method. [1] [2] [3]Other Changes:
agent/logging.go
: Removed the file entirely as it contained MQTT-specific logging implementations.go.mod
: Removed the dependency onpaho.mqtt.golang
from the module requirements. [1] [2]