fix: selector applies to all block matches #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go test coverage
Total coverage: 0.8% |
leoparente
changed the title
mfiedorowicz
approved these changes
Feb 26, 2025
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
processSelectorfunction in thegitConfigManagerand updates to the documentation for the Orb Agent's configuration. The key changes are focused on improving the handling of policy paths and clarifying the documentation.Improvements to
processSelectorfunction:agent/configmgr/git.go: Replaced the list of policy paths with a set to ensure uniqueness, and added logic to convert the set back to a list before returning it. This change ensures that duplicate policy paths are not included in the results. Also ensure that every match applies and not only the first one.Documentation updates:
docs/configs/git.md: Updated the example directory structure to reflect a more organized layout and added a new example for a selector that matches all agents. [1] [2]selectorsection to indicate that an empty selector matches all agents.