Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retrieve deviation by id rpc #234

Conversation

mfiedorowicz
Copy link
Member

@mfiedorowicz mfiedorowicz commented Jan 16, 2025

This pull request introduces a new feature to retrieve deviations by their ID in the diode project. The changes span multiple files, including protocol buffer definitions, SQL queries, and Go code for the repository and generated protobuf files. The most important changes include adding new request and response message types, updating the service definition, and implementing the corresponding repository method.

New feature: Retrieve deviation by ID

Minor updates

  • Updated protoc-gen-go versions in generated files to v1.36.3. [1] [2]

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Copy link

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.20s github.com/netboxlabs/diode/diode-server/ingester 75.4% 9 0 0
🟢 PASS 1.06s github.com/netboxlabs/diode/diode-server/migrator 70.4% 4 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.73s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.42s github.com/netboxlabs/diode/diode-server/reconciler 76.5% 41 0 0
🟢 PASS 1.09s github.com/netboxlabs/diode/diode-server/reconciler/applier 81.8% 1 0 0
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.33s github.com/netboxlabs/diode/diode-server/reconciler/differ 82.5% 92 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 74.0%

@mfiedorowicz mfiedorowicz merged commit 2ad7977 into feat-postgres-implementation-and-enhancements Jan 16, 2025
3 checks passed
@mfiedorowicz mfiedorowicz deleted the feat-retrieve-deviation-by-id-rpc branch January 16, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants