-
Notifications
You must be signed in to change notification settings - Fork 10
Fixes running in netbox-docker with errors on version strings #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
`packaging.version.InvalidVersion: Invalid version: '4.2.3-Docker-3.2.0'` If it's new enough to break due to this reason, it's already on the new module names for import. Alternative is to check `settings.RELEASE.version` vs `settings.VERSION`
Tested this. Works! Thanks! |
Is there any blockers to merge this PR? |
Hi @biwhite, apologies for keeping you waiting. Thanks for the fix, all looks good 🙌 |
Hi, I've removed the unused variables from the try/except blocks. Thanks |
Hi, can someone please review this PR, it's a blocker for using the plugin on netbox-docker installations. Thanks. |
I think we're waiting on @biwhite to sign the CLA |
Sorry, I'd missed it was waiting on me signing CLA! Now done. |
Will this ever be merged? |
Apologies for delay in response/action lately, we've been extremely busy with release of diode and diode-netbox-plugin 1.0.0, which already should have this issue resolved, with minimum supported NetBox version 4.2.3 and dropping backwards compatibility with NetBox < 4.1. |
That's exactly why I am asking :) I saw the announcement in the NetBox blog and was hoping to try it, but I still can't install the diode plugin. |
packaging.version.InvalidVersion: Invalid version: '4.2.3-Docker-3.2.0'
If it's new enough to break due to this reason, it's already on the new module names for import.
Alternative is to check
settings.RELEASE.version
vssettings.VERSION