Closes #20210: Implement new version of API token #20477
+1,016
−355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
commented
Oct 3, 2025
| return '' | ||
| # Skip dummy records (e.g. available VLANs or IP ranges replacing individual IPs) | ||
| if type(record) is not model or not getattr(record, 'pk', None): | ||
| if not isinstance(record, model) or not getattr(record, 'pk', None): |
There was a problem hiding this comment.
Fix this to work with proxy models as well as concrete. (Needed to support UserToken)
jeremystretch
requested review from
a team and
bctiemann
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #20210
keytoplaintext(used only for v1 tokens)versionto denote v1/v2 tokenskey,pepper_id, andhmac_digestfields to store v2 token attributesAPI_TOKEN_PEPPERSconfiguration parameterTokenAuthenticationto recognize both token versions and to validate v2 tokensget_current_pepper()utility function to retrieve the most recent peppertoken.htmltemplate for the account view