Skip to content

#19561 fix changelog table on profile page #19563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

arthanson
Copy link
Collaborator

Fixes: #19561

Removes the split from the queryset for the changelog on the profile page, I don't see any reason to keep it there. Added the pagination so can get all the info.
Monosnap User Profile | NetBox 2025-05-22 14-33-01

@arthanson arthanson marked this pull request as ready for review May 22, 2025 21:51
@arthanson arthanson requested review from a team and jeremystretch and removed request for a team May 22, 2025 21:51
@jakobsen-lrz
Copy link

jakobsen-lrz commented May 23, 2025

Hello,

im sorry, but i just noticed that this Problem needs to be fixed in another file as well. In netbox/user/views.py at about line 75.

@register_model_view(User)
class UserView(generic.ObjectView):
    queryset = User.objects.all()
    template_name = 'users/user.html'

    def get_extra_context(self, request, instance):
        changelog = ObjectChange.objects.restrict(request.user, 'view').filter(user=instance)[:20]
        changelog_table = ObjectChangeTable(changelog)
        changelog_table.configure(request)

        return {
            'changelog_table': changelog_table,
        }

Can you please include a fix for this as well? Thanks.

@arthanson arthanson removed the request for review from jeremystretch May 29, 2025 15:56
@arthanson arthanson marked this pull request as draft May 29, 2025 15:56
@arthanson arthanson requested review from a team and jeremystretch and removed request for a team May 29, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant view my user profile, it shows an exception.
2 participants