Skip to content

Fixes #17319: Arrange device and module type fields behind tab in com… #19357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

jnovinger
Copy link
Member

…ponent template forms

Fixes: #17319

  • Updates all device/module component template forms (but only those that display both fields) to arrange device_type and module_type fields in a tabbed group.
  • Included module component templates forms even though the initial ticket only specified device component template forms, since most of them are shared forms.
  • Contemplated creating a re-usable sub-Fieldset definition and plugging that in, but it seemed less readable plus I didn't see us doing anything like that elsewhere.

@jnovinger jnovinger requested review from a team and bctiemann and removed request for a team April 29, 2025 17:21
@bctiemann bctiemann merged commit fadc358 into main Apr 30, 2025
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrange the device type & module type fields of component template model forms behind tabs
2 participants