Closes #18224: Apply all registered request processors when running custom scripts #18225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
approved these changes
Dec 12, 2024
candlerb
reviewed
Dec 23, 2024
| @@ -100,5 +100,7 @@ def run(self, data, request=None, commit=True, **kwargs): | |||
|
|
|||
| # Execute the script. If commit is True, wrap it with the event_tracking context manager to ensure we process | |||
There was a problem hiding this comment.
Given the removed code line below, is the comment now obsolete? ("If commit is True, wrap it with the event_tracking context manager...")
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #18224
Invoke all context managers listed in
registry['request_processors']when running a custom script background job.