Fixes: #18037 - Bound VLANGroup VLAN ID max by VLAN_VID_MAX
#18041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear, this does not fix the list issue, I am not sure where that code is going to come into play (Checked the annotation on the custom queryset and the table and nothing there looks to cause any issues), however this does prevent VID's > 4094 from being created. It is likely in ranges_to_strings() from vid_ranges_list but changing that may have unintended impacts. |
jeremystretch
approved these changes
Nov 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18037 - Restrict VLANGroup VID max to 4094
VLAN_VID_MAX