7699 Add Scope to Cluster #17848
Merged
7699 Add Scope to Cluster #17848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Oct 25, 2024
| @@ -148,7 +148,7 @@ def get_for_virtualmachine(self, vm): | |||
|
|
|||
| # Find all relevant VLANGroups | |||
| q = Q() | |||
| site = vm.site or vm.cluster.site | |||
| site = vm.site or vm.cluster._site | |||
There was a problem hiding this comment.
This should be adapted for the other scope types as well, as VLAN groups can also be assigned to different scopes.
There was a problem hiding this comment.
? Not sure I follow this - this is for VLAN, not VLANGroup and any higher scope assignment will filter down to _site - so _site should pick up all the assignments?
|
FYI: I don't think the build breaking is from the PR, looks like from background task running... |
jeremystretch
requested changes
Oct 30, 2024
netbox/virtualization/migrations/0043_clusters_cached_relations.py
Outdated
Show resolved
Hide resolved
jeremystretch
approved these changes
Nov 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7699
Added mixins as well, not sure if they should be in netbox/ or dcim/ but the filtersets would need to be in something like filterset_mixins, so not sure if that is good. Can move them if desired.
Once this is approved will make a separate PR to move the already implemented scoped models to use these mixins.